-
Notifications
You must be signed in to change notification settings - Fork 25k
Proper NativeAnimated node invalidation on Android #10837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper NativeAnimated node invalidation on Android #10837
Conversation
|
By analyzing the blame information on this pull request, we identified @janicduplessis and @kmagiera to be potential reviewers. |
janicduplessis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to change one of the calls to mUpdatedNodes from add to put in setAnimatedNodeOffset. The rests looks good to me, gonna test it in my app.
|
Tested it and it works well, it fixed an issue on android where sometimes there was a white screen after poping a route on android with NavigationExperimental + native animations. |
|
@janicduplessis Not sure if it has something to do with this particular PR, but is there any chance that the 8968 have the same root cause? Like not proper node invalidation after the node is removed from the array of siblings with the different zIndexes? |
|
This only affects native driven animations (when you start an animation with useNativeDriver=true) so unless you are using that it doesn't seems related. |
4977cfd to
cb19cc5
Compare
|
@facebook-github-bot shipit |
Summary: This diff attempts to fix a number of Android native animation bugs related to incomplete node invalidation, e.g. facebook#10657 (comment). For full correctness, we should mark any node as needing update when it is: - created - updated (value nodes) - attached to new parents - detached from old parents - attached to a view (prop nodes) cc/ janicduplessis Closes facebook#10837 Differential Revision: D4166446 fbshipit-source-id: dbf6b9aa34439e286234627791bb7fef647c8396
This diff attempts to fix a number of Android native animation bugs related to incomplete node invalidation, e.g. #10657 (comment).
For full correctness, we should mark any node as needing update when it is:
cc/ @janicduplessis