[Android] Navigator transitions broken on 0.13

[satya164]

So, I upgraded my RN version in package.json and build.gradle and found that Navigator transitions are broken. I tried adding a configureScene property with no success.

[maxim-c]

same issue. All configs Navigator.SceneConfigs with translate doesn't work, only this strange fade effect like in satya164 case.
FadeAndroid scene changes this ugly fade to little more better...

[mangogogos]

+1

[pagrawl3]

same issue here as well, none of the slide transitions work, but the fade transitions work without a problem.

[astreet]

Thanks for the report and +1's everyone, @ericvicenti can you take a look?

[JonnyBGod]

+1

[satya164]

Any updates on this?

[ericvicenti]

I haven't seen any changes to Navigator that would cause this, and there is no platform-specific code that would cause breakage only on Android.

To perform animations, Navigator calls setNativeProps on views within a requestAnimationFrame timer.

Maybe somebody could try bisecting to identify the breakage? I don't have bandwidth to figure this out in the next few weeks.

[mbrochh]

I simply created the AwesomeProject tutorial and then added a Navigator to it and used the FloatFromRight transition. It works on iOS but it does not work on Android. The only transition that seems to work on Android is FadeAndroid, but that one is so subtle, it's hardly noticeable.

[davidstubbs]

I'm not entirely sure how it was broken, but the reason most transitions don't work is that they're using the wrong native prop.

buildStyleInterpolator creates a style with the transformMatrix property. Android expects the decomposed matrix in decomposedMatrix.

I hacked a change in Navigator.js _transitionSceneStyle which "fixes" the transitions (as in they work afterwards, but I'm sure this code change isn't really the one wanted):

    ...
    var didChange = useFn(styleToUse, directionAdjustedProgress);
    //
    if (styleToUse.transformMatrix)
      styleToUse = {...styleToUse, decomposedMatrix: MatrixMath.decomposeMatrix(styleToUse.transformMatrix)}
    //
    if (didChange) {
    ...

This is my first look at any of this code, so I'm very unsure how to go about fixing this for real.
Any pointers?