-
Notifications
You must be signed in to change notification settings - Fork 24.6k
Refreshing when multiple Modals open will keep the first one open after refresh #16037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
This is still an issue with 0.53.3 and would appreciate it being looked into by someone. |
We just updated to react-native .49 and this started happening in a couple places throughout the app. I can confirm that the condition to show the modal is set to false and the modal that remains on the screen is completely unresponsive. Same as above that we need to recompile our app to fix this. Ours is slightly different in the way that we have a modal open, then we flip the condition to show the modal to false. The modal then starts to fade out and disappear then instantly comes back and is then unresponsive and takes up the whole screen so we cannot interact with anything underneath the modal. The modal then stays on the screen until we rebuild the app, refreshing seems to have no effect. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
Activity. This is still very much a bug. |
RN v0.54.4, this exists. |
Also running into this issue. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
I think this issue is resolved. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
Not stale, still an issue with |
yep, experiencing it in 2019... |
Still the case on React Native 0.58.3 |
I'm experiencing it too |
same problem here.. modals keep poping up when i save something in the project |
) Summary: Fixes facebook#16037. We need to keep the order of Modals, if we dismiss Modal randomly(before we use hash table), some Modals may not dismiss successfully. This PR should based on facebook#24959. ## Changelog [iOS] [Fixed] - Keep the order of Modals that we can dismiss in sequence Pull Request resolved: facebook#24961 Differential Revision: D15621858 Pulled By: cpojer fbshipit-source-id: 964729f8f4584995f4e1dd527af4b61534d369ba
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS Sierra 10.12.6
Node: 8.3.0
Yarn: 1.0.2
npm: 2.15.12
Watchman: 4.9.0
Xcode: Xcode 8.3.3 Build version 8E3004b
Android Studio: 2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: ^0.48.1 => 0.48.2
Target Platform: iOS (10.3)
Steps to Reproduce
See demo app below.
Initial background color is
blue
, first modal isred
, second modalblack
.red
modal.black
modal.Expected Behavior
I would expect all modals to close and not to reopen after refreshing the app.
Actual Behavior
You'll notice that immediately after refreshing the app the second
black
modal becomes active again (while the firstred
modal does not) and the entire screen is unresponsive. The only way out of this state is to recompile the app completely.I haven't confirmed whether this also happens on Android.
Reproducible Demo
The text was updated successfully, but these errors were encountered: