-
Notifications
You must be signed in to change notification settings - Fork 24.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove import of
com.facebook.react.ReactSettingsExtension
(#44850)
Summary: Pull Request resolved: #44850 I'm removing this line from settings.gradle: ``` import com.facebook.react.ReactSettingsExtension ``` and just using a fully qualified class name in the `configure{}` block as imports cannot be conditionally included and is making hard for RNTA to integrated those changes. Changelog: [Internal] [Changed] - Remove import of `com.facebook.react.ReactSettingsExtension` Reviewed By: huntie Differential Revision: D58354443 fbshipit-source-id: bc45516661318021a042e1c5921e28d7217cacbc
- Loading branch information
1 parent
6937c70
commit feeb4b7
Showing
3 changed files
with
3 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
import com.facebook.react.ReactSettingsExtension | ||
pluginManagement { includeBuild("../node_modules/@react-native/gradle-plugin") } | ||
plugins { id("com.facebook.react.settings") } | ||
extensions.configure(ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand() } | ||
extensions.configure(com.facebook.react.ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand() } | ||
rootProject.name = 'HelloWorld' | ||
include ':app' | ||
includeBuild('../node_modules/@react-native/gradle-plugin') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters