Cleanup the .github/workflows folder (#44857)

Summary:
Just doing some cleanup of the `.github/workflows` folder:
* apply-version-label-issue.yml hasn't been working since 0.72
* ios-tests is unnecessary as it's now covered by test-all
* nightlies-feedback.yml was experimental and last execution was ~5 months ago.

We can still recover them from the Git history if necessary.

## Changelog:

[INTERNAL] - Cleanup the .github/workflows folder

Pull Request resolved: #44857

Test Plan: Will wait for CI result

Reviewed By: NickGerleman

Differential Revision: D58362912

Pulled By: cortinico

fbshipit-source-id: d886e4f077eebfdf906169f09f96a950a361cab7

.github/workflows/needs-attention.yml

@@ -2,7 +2,7 @@ name: Issue Needs Attention
 # This workflow is triggered on issue comments.
 on:
   issue_comment:
-    types: created
+    types: [created]
 
 permissions:
   contents: read

.github/workflows/on-issue-labeled.yml

@@ -2,7 +2,7 @@ name: On Issue Labeled
 # This workflow is triggered when a label is added to an issue.
 on:
   issues:
-    types: labeled
+    types: [labeled]
 
 permissions:
   contents: write

.github/workflows/stale-bot.yml

@@ -1,4 +1,4 @@
-name: Mark stale issues and pull requests
+name: Stale bot
 on:
   schedule:
     - cron: "*/10 5 * * *"

.github/workflows/test-all.yml

@@ -1,12 +1,12 @@
-name: test-all
+name: Test All
 
 on:
-    workflow_dispatch:
-    pull_request:
-    push:
-      branches:
-        - main
-        - "*-stable"
+  workflow_dispatch:
+  pull_request:
+  push:
+    branches:
+      - main
+      - "*-stable"
 
 jobs:
   set_release_type:
@@ -374,7 +374,8 @@ jobs:
           path: /tmp/hermes/dSYM/${{ matrix.flavor }}
   test_ios_rntester_ruby_3_2_0:
     runs-on: macos-13
-    needs: [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos]
+    needs:
+      [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos]
     env:
       HERMES_WS_DIR: /tmp/hermes
       HERMES_TARBALL_ARTIFACTS_DIR: /tmp/hermes/hermes-runtime-darwin
@@ -389,7 +390,8 @@ jobs:
           react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
   test_ios_rntester_dynamic_frameworks:
     runs-on: macos-13
-    needs: [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos]
+    needs:
+      [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos]
     env:
       HERMES_WS_DIR: /tmp/hermes
       HERMES_TARBALL_ARTIFACTS_DIR: /tmp/hermes/hermes-runtime-darwin
@@ -410,7 +412,8 @@ jobs:
           react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
   test_ios_rntester:
     runs-on: macos-13
-    needs: [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos]
+    needs:
+      [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos]
     env:
       HERMES_WS_DIR: /tmp/hermes
       HERMES_TARBALL_ARTIFACTS_DIR: /tmp/hermes/hermes-runtime-darwin
@@ -563,7 +566,7 @@ jobs:
       image: reactnativecommunity/react-native-android:latest
       env:
         TERM: "dumb"
-        GRADLE_OPTS: '-Dorg.gradle.daemon=false'
+        GRADLE_OPTS: "-Dorg.gradle.daemon=false"
         # By default we only build ARM64 to save time/resources. For release/nightlies/prealpha, we override this value to build all archs.
         ORG_GRADLE_PROJECT_reactNativeArchitectures: "arm64-v8a"
     steps:
@@ -612,7 +615,7 @@ jobs:
       image: reactnativecommunity/react-native-android:latest
       env:
         TERM: "dumb"
-        GRADLE_OPTS: '-Dorg.gradle.daemon=false'
+        GRADLE_OPTS: "-Dorg.gradle.daemon=false"
         # By default we only build ARM64 to save time/resources. For release/nightlies/prealpha, we override this value to build all archs.
         ORG_GRADLE_PROJECT_reactNativeArchitectures: "arm64-v8a"
         # Repeated here, as the environment key in this executor will overwrite the one in defaults
@@ -661,12 +664,20 @@ jobs:
           path: packages/rn-tester/android/app/build/outputs/apk/
   build_npm_package:
     runs-on: 8-core-ubuntu
-    needs: [set_release_type, prepare_hermes_workspace, build_hermes_macos, build_hermesc_linux, build_hermesc_windows,build_android]
+    needs:
+      [
+        set_release_type,
+        prepare_hermes_workspace,
+        build_hermes_macos,
+        build_hermesc_linux,
+        build_hermesc_windows,
+        build_android,
+      ]
     container:
       image: reactnativecommunity/react-native-android:latest
       env:
         TERM: "dumb"
-        GRADLE_OPTS: '-Dorg.gradle.daemon=false'
+        GRADLE_OPTS: "-Dorg.gradle.daemon=false"
         # By default we only build ARM64 to save time/resources. For release/nightlies/prealpha, we override this value to build all archs.
         ORG_GRADLE_PROJECT_reactNativeArchitectures: "arm64-v8a"
         # Repeated here, as the environment key in this executor will overwrite the one in defaults
@@ -765,15 +776,15 @@ jobs:
         uses: actions/[email protected]
         with:
           node-version: 18
-          cache: 'yarn'
+          cache: yarn
       - name: Install dependencies
         run: yarn install --non-interactive
       - name: Build packages
         run: yarn build
       # Continue with publish steps
       - name: Set npm credentials
         if: needs.set_release_type.outputs.RELEASE_TYPE == 'release' ||
-            needs.set_release_type.outputs.RELEASE_TYPE == 'nightly'
+          needs.set_release_type.outputs.RELEASE_TYPE == 'nightly'
         run: echo "//registry.npmjs.org/:_authToken=${{ secrets.CIRCLE_NPM_TOKEN }}" > ~/.npmrc
       - name: Publish NPM
         shell: bash
@@ -833,14 +844,14 @@ jobs:
       PROJECT_NAME: AndroidTemplateProject
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
       TERM: "dumb"
-      GRADLE_OPTS: '-Dorg.gradle.daemon=false'
+      GRADLE_OPTS: "-Dorg.gradle.daemon=false"
       ORG_GRADLE_PROJECT_reactNativeArchitectures: "arm64-v8a"
     continue-on-error: true
     strategy:
       fail-fast: false
       matrix:
         flavor: [Debug, Release]
-        architecture: [ NewArch, OldArch ]
+        architecture: [NewArch, OldArch]
         jsengine: [Hermes, JSC]
     steps:
       - name: Checkout