iOS: Fixes Switch component incorrectly renders as toggled on even though value prop is hardcoded to false (#50049)

zhongwuzw · fabriziocucci · commit 78d60923858b · 2025-07-09T11:35:08.000+01:00
Summary: Fixes #50026 ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Fixes Switch component incorrectly renders as toggled on even though value prop is hardcoded to false Pull Request resolved: #50049 Test Plan: Repro please see #50026. Reviewed By: javache Differential Revision: D71307864 Pulled By: cipolleschi fbshipit-source-id: 57238296842229cf2f23a3f44134f43e27b54609
diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/Switch/RCTSwitchComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/Switch/RCTSwitchComponentView.mm
@@ -60,7 +60,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
   const auto &newSwitchProps = static_cast<const SwitchProps &>(*props);
 
   // `value`
-  if (oldSwitchProps.value != newSwitchProps.value) {
+  if (!_isInitialValueSet || oldSwitchProps.value != newSwitchProps.value) {
     BOOL shouldAnimate = _isInitialValueSet == YES;
     [_switchView setOn:newSwitchProps.value animated:shouldAnimate];
   }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &`
`60`	`60`	`const auto &newSwitchProps = static_cast<const SwitchProps &>(*props);`
`61`	`61`
`62`	`62`	// `value`
`63`		`- if (oldSwitchProps.value != newSwitchProps.value) {`
	`63`	`+ if (!_isInitialValueSet \|\| oldSwitchProps.value != newSwitchProps.value) {`
`64`	`64`	`BOOL shouldAnimate = _isInitialValueSet == YES;`
`65`	`65`	`[_switchView setOn:newSwitchProps.value animated:shouldAnimate];`
`66`	`66`	`}`