Skip to content

Commit

Permalink
Improved <ImageBackground>
Browse files Browse the repository at this point in the history
Reviewed By: sahrens

Differential Revision: D5214113

fbshipit-source-id: 1eca2347f97a1ff13f71906688a33b9ed7a3a7f4
  • Loading branch information
shergin authored and facebook-github-bot committed Jun 13, 2017
1 parent c78ddf2 commit 7707905
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions Libraries/Image/ImageBackground.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ class ImageBackground extends React.Component {
right: 0,
top: 0,
bottom: 0,
// Temporary Workaround:
// Current (imperfect yet) implementation of <Image> overwrites width and height styles
// (which is not quite correct), and these styles conflict with explicitly set styles
// of <ImageBackground> and with our internal layout model here.
// So, we have to proxy/reapply these styles explicitly for actual <Image> component.
// This workaround should be removed after implementing proper support of
// intrinsic content size of the <Image>.
width: style.width,
height: style.height,
},
imageStyle,
]}
Expand Down

0 comments on commit 7707905

Please sign in to comment.