Skip to content

Commit

Permalink
Fix react-native CLI (internal and external one)
Browse files Browse the repository at this point in the history
Summary:
- Fix wrong debugger-ui path
- Override host and port using args

Reviewed By: yungsters

Differential Revision: D8731159

fbshipit-source-id: ca8ad76a02eda9e0b9cdb1a952aa5631d660868f
  • Loading branch information
Alexey Kureev authored and facebook-github-bot committed Jul 4, 2018
1 parent 079bf3f commit 5067540
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion local-cli/server/middleware/MiddlewareManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports = class MiddlewareManager {
options: Options;

constructor(options: Options) {
const debuggerUIFolder = path.join(__dirname, 'util', 'debugger-ui');
const debuggerUIFolder = path.join(__dirname, '..', 'util', 'debugger-ui');

this.options = options;
this.app = connect()
Expand Down
2 changes: 2 additions & 0 deletions local-cli/server/runServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ async function runServer(args: Args, config: ConfigT) {
: config.getTransformModulePath(),
watch: !args.nonPersistent,
},
host: args.host,
port: args.port,
});

// In Node 8, the default keep-alive for an HTTP connection is 5 seconds. In
Expand Down

0 comments on commit 5067540

Please sign in to comment.