Skip to content

Commit

Permalink
Fix RNTester ignoring build mode and always using JSC
Browse files Browse the repository at this point in the history
Summary:
RNTester ended up using JSC for both jscDebug and hermesDebug. Now it uses the
correct one. It still includes all executors, but it's a step in the right
direction.

ChangeLog: [General] [Fixed] RNTester now uses the VM specified in the build flavor

Reviewed By: passy

Differential Revision: D19752239

fbshipit-source-id: 0db4e5201fc80c2a0b91531e3f4333148c1d9c7c
  • Loading branch information
willholen authored and facebook-github-bot committed Feb 10, 2020
1 parent ca81037 commit 2bc2b43
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions RNTester/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ android {
}
}

configurations {
hermesDebugImplementation {}
hermesReleaseImplementation {}
}

dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])

Expand All @@ -169,8 +174,8 @@ dependencies {
implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0"

def hermesPath = '$projectDir/../../../../node_modules/hermes-engine/android/'
debugImplementation files(hermesPath + "hermes-debug.aar")
releaseImplementation files(hermesPath + "hermes-release.aar")
hermesDebugImplementation files(hermesPath + "hermes-debug.aar")
hermesReleaseImplementation files(hermesPath + "hermes-release.aar")

debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") {
exclude group:'com.facebook.fbjni'
Expand All @@ -185,8 +190,8 @@ dependencies {
}

if (useIntlJsc) {
implementation 'org.webkit:android-jsc-intl:+'
jscImplementation 'org.webkit:android-jsc-intl:+'
} else {
implementation 'org.webkit:android-jsc:+'
jscImplementation 'org.webkit:android-jsc:+'
}
}

0 comments on commit 2bc2b43

Please sign in to comment.