-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: ## Description This diff introduces `NativeModulePerfLogger`, its BUCK, Cocoapod, android-ndk targets. This diff also wires up those targets into the React Native bridge and TurboModules targets, so that we get signal on if the code compiles. This diff also introduces `TurboModulePerfLogger`, which is a namespace that holds the `NativeModulePerfLogger` that'll do perf-logging for TurboModules. ## How will perflogging work on iOS? 1. Each application will, during React Native initialization, create a NativeModule perf logger. 2. If TurboModules are enabled, we'll call `TurboModulePerfLogger::setInstance(perfLogger)`. If TurboModules are disabled, we'll call `NativeModulePerfLogger::setInstance(perfLogger)`. 3. TurboModules, when they're created and used, will log events via `TurboModulePerfLogger::getInstance()`. NativeModules (i.e: bridge modules), when they're created and used, will log events via the `NativeModulePerfLogger::getInstance()`. > **Note:** The NativeModule system will log events for non-TurboModules as well. Maybe we should log events for only NativeModules that conform to the `TurboModule` interface, when TurboModules are disabled. This'll ensure a fair comparison between the two systems. ## How will perflogging work on Android? Please see the subsequent diff. allow-large-files Changelog: [Both][Added] - Introduce `NativeModulePerfLogger` Reviewed By: PeteTheHeat Differential Revision: D21318053 fbshipit-source-id: 6ddf5b5a80bdc4076d2dd6588067e2b0ec8c2c6b
- Loading branch information
1 parent
c3a3d42
commit 0486640
Showing
14 changed files
with
488 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| Checks: '> | ||
| clang-diagnostic-*, | ||
| ' | ||
| ... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # This source code is licensed under the MIT license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| LOCAL_PATH := $(call my-dir) | ||
|
|
||
| include $(CLEAR_VARS) | ||
|
|
||
| # Header search path for all source files in this module. | ||
| LOCAL_C_INCLUDES := $(LOCAL_PATH)/ReactCommon | ||
|
|
||
| # Header search path for modules that depend on this module | ||
| LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH) | ||
|
|
||
| LOCAL_CFLAGS += -fexceptions -frtti -std=c++14 -Wall | ||
|
|
||
| # Name of this module. | ||
| LOCAL_MODULE := perflogger | ||
|
|
||
| # Compile all local c++ files under ./ReactCommon | ||
| LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/ReactCommon/*.cpp) | ||
|
|
||
| # Build the files in this directory as a shared library | ||
| include $(BUILD_STATIC_LIBRARY) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "rn_xplat_cxx_library", "subdir_glob") | ||
|
|
||
| rn_xplat_cxx_library( | ||
| name = "perflogger", | ||
| srcs = glob(["**/*.cpp"]), | ||
| header_namespace = "", | ||
| exported_headers = subdir_glob( | ||
| [ | ||
| ("ReactCommon", "*.h"), | ||
| ], | ||
| prefix = "ReactCommon", | ||
| ), | ||
| compiler_flags = [ | ||
| "-fexceptions", | ||
| "-frtti", | ||
| "-std=c++14", | ||
| "-Wall", | ||
| "-Wno-global-constructors", | ||
| ], | ||
| fbandroid_labels = [ | ||
| "supermodule:android/default/public.react_native.infra", | ||
| ], | ||
| fbobjc_labels = [ | ||
| "supermodule:ios/default/public.react_native.infra", | ||
| ], | ||
| platforms = (ANDROID, APPLE), | ||
| preferred_linkage = "static", | ||
| preprocessor_flags = [ | ||
| "-DLOG_TAG=\"ReactNative\"", | ||
| "-DWITH_FBSYSTRACE=1", | ||
| ], | ||
| visibility = [ | ||
| "PUBLIC", | ||
| ], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # This source code is licensed under the MIT license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| require "json" | ||
|
|
||
| package = JSON.parse(File.read(File.join(__dir__, "..", "..", "package.json"))) | ||
| version = package['version'] | ||
|
|
||
| source = { :git => 'https://github.com/facebook/react-native.git' } | ||
| if version == '1000.0.0' | ||
| # This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in. | ||
| source[:commit] = `git rev-parse HEAD`.strip | ||
| else | ||
| source[:tag] = "v#{version}" | ||
| end | ||
|
|
||
| folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32' | ||
| folly_version = '2020.01.13.00' | ||
| boost_compiler_flags = '-Wno-documentation' | ||
|
|
||
| Pod::Spec.new do |s| | ||
| s.name = "React-perflogger" | ||
| s.version = version | ||
| s.summary = "-" # TODO | ||
| s.homepage = "https://reactnative.dev/" | ||
| s.license = package["license"] | ||
| s.author = "Facebook, Inc. and its affiliates" | ||
| s.platforms = { :ios => "10.0", :tvos => "10.0" } | ||
| s.source = source | ||
| s.source_files = "**/*.{cpp,h}" | ||
| s.header_dir = "ReactCommon" | ||
| end |
Oops, something went wrong.