Change 'use' to 'lose' to signify that functions are still accessible #3937
Conversation
The statement at the end says that since the generated abstract class itself extends ReactContextBaseJavaModule, all the functions are still accessible. But the sentence reads "should not use", which does not make sense, and "should not lose" should instead be used.
|
Hi @ksshp! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please sign CLA |
|
@NickGerleman Please help to check #3949 instead, I'm not sure if I can sign the CLA from this account. |
3 participants
The statement at the end says that since the generated abstract class itself extends ReactContextBaseJavaModule, all the functions are still accessible. But the sentence reads "should not use", which does not make sense, and "should not lose" should instead be used.