Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Jul 7, 2023

Adds guidance to our Contributing docs around the introduction of a monorepo build setup.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 7e37c1d
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64a835fb3080bf0008ffeed5
😎 Deploy Preview https://deploy-preview-3788--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cortinico cortinico assigned cortinico and unassigned cortinico Jul 7, 2023
@cortinico cortinico added the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Jul 7, 2023
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

@cortinico cortinico merged commit 6af9b5e into facebook:main Jul 8, 2023
huntie added a commit to huntie/react-native-website that referenced this pull request Aug 1, 2023
Removes mandatory run of `yarn build/watch` when developing Node.js packages — matching the updated build setup in facebook/react-native#38718 (these packages are now set up to run from source during development).

Partially reverts facebook#3788 "[docs] Add guidance on repo build scripts"
sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Aug 5, 2023
* Update Debugging docs to no longer recommend Remote debugging (facebook#3702)

Co-authored-by: Alex Hunt <[email protected]>

* Bump fast-xml-parser from 4.2.4 to 4.2.5 (facebook#3777)

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.2.4 to 4.2.5.
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v4.2.4...v4.2.5)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Upgrade got dependency (facebook#3776)

* feature: Move to GA4 (UA being reprecated in June)

Google Analytics is deprecating the older clients. This is the first
step to enable to newer client. This should be followed with a step to
remove the old client once we know data is flowing.

* Upgrade got dependency

Resolves dependabot alerts #26

* Use `https` links over `http` (facebook#3761)

* [docs] Update/simplify info around Metro for env setup (facebook#3673)

* [docs] Add Metro guide, update Metro config references (facebook#3772)

* [docs] Remove static config note in Metro guide, adjust formatting (facebook#3782)

* Improving Grammar and Clarity.md (facebook#3783)

Improving Grammar and Clarity in React Native's Performance Description

* Fix docs for onResponderGrant (facebook#3785)

* react-native-gradle-plugin renamed to @react-native/gradle-plugin (facebook#3786)

* Update _integration-with-existing-apps-kotlin.md

* Update _integration-with-existing-apps-kotlin.md

* Update _integration-with-existing-apps-java.md

* Update _integration-with-existing-apps-java.md

* Update _integration-with-existing-apps-kotlin.md

* Update how-to-build-from-source for 0.72+ (facebook#3659)

* Clarify documentation for turbomodules (facebook#3787)

* Clarify documentation for turbomodules

`codegenConfig` is stated in text that it's an array, but in code example it's an object.

Either the text or the code example should change.

* Fix linting issue

* Update the PR to reflect knowledge that the code sample is correct but documentation wrong

* Update FlatList Optimization Guide for FCs (facebook#3700)

* Update FlatList Optimization Guide for FCs

* fix lint

* Update docs/optimizing-flatlist-configuration.md

---------

Co-authored-by: Егорик <[email protected]>
Co-authored-by: Nick Gerleman <[email protected]>

* [docs] Add guidance on repo build scripts (facebook#3788)

* [docs] add Chain React 2023 playlist link on staying-updated (facebook#3790)

* Bump semver from 5.7.1 to 5.7.2 (facebook#3791)

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docusaurus v2.4.1 (facebook#3778)

* Bump word-wrap from 1.2.3 to 1.2.4 (facebook#3794)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: iOS backwards compatibility update (facebook#3775)

* Update backward-compatibility-fabric-components.md

Ensure backwards-compat docs refer to all necessary code changes.

reactwg/react-native-new-architecture#8 (comment)

* Update docs/the-new-architecture/backward-compatibility-fabric-components.md

Co-authored-by: Riccardo Cipolleschi <[email protected]>

* trim whitespace and fix typo

---------

Co-authored-by: Riccardo Cipolleschi <[email protected]>

* [website] swizzle DocVersionBanner, tweak wording (facebook#3800)

* tweak: improve wordiness on docs about bumping monorepo packages (facebook#3805)

* Fix typo in architecture-glossary.md (facebook#3806)

* docs: change js to tsx (facebook#3808)

* Update website to use JDK 17 (facebook#3812)

LGTM.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Gabriel Donadel Dall'Agnol <[email protected]>
Co-authored-by: Alex Hunt <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Blake Friedman <[email protected]>
Co-authored-by: Pranav Yadav <[email protected]>
Co-authored-by: Waseem Kurne <[email protected]>
Co-authored-by: Pieter De Baets <[email protected]>
Co-authored-by: Nicola Corti <[email protected]>
Co-authored-by: Stefan Wallin <[email protected]>
Co-authored-by: Егорик <[email protected]>
Co-authored-by: Егорик <[email protected]>
Co-authored-by: Nick Gerleman <[email protected]>
Co-authored-by: David Leuliette <[email protected]>
Co-authored-by: Sébastien Lorber <[email protected]>
Co-authored-by: Connor Mullins <[email protected]>
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Co-authored-by: Bartosz Kaszubowski <[email protected]>
Co-authored-by: Lorenzo Sciandra <[email protected]>
Co-authored-by: Stanley Ugwu <[email protected]>
Co-authored-by: kong <[email protected]>
@huntie huntie deleted the contributing-build-guidance branch October 2, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged p: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants