Update scrollview.md to reflect duration argument #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook/react-native#17422 adds the ability to control the duration of a scrollView animation, for Android only.
|
Will need to wait until that PR is merged. |
charpeni
added
the
🕐 Waiting on PR
|
Oops, something went wrong with this deploy preview. @charpeni can you look at this? |
|
Synced documentation here with the comments in the ScrollView.js code from this PR: |
|
Thanks, can you also rebase your changes on master? We'll have a working deploy preview. |
|
@charpeni done, I think. |
|
Deploy preview for react-native ready! Built with commit 129a26c https://deploy-preview-115--react-native.netlify.com Changes to Thank you for your contributions. |
|
I'm landing this change to RN imminently. |
sunnylqm
referenced
this pull request
in reactnativecn/react-native-website
Feb 8, 2019
* [android] document required Network Security Config for React Native packager (#772) * add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs * add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs * Update navigation.md (#770) Use createAppContainer instead of createAppNavigator see function declaration here https://github.com/react-navigation/react-navigation/blob/master/src/react-navigation.js#L5 * Update README.md Fixed a few spelling errors in README.md * Deprecating NavigatorIOS (#776) * Deprecating NavigatorIOS * Remove navigator ios * Remove TabBarIOS, TabBarIOS.Item, NavigatorIOS from docs * Make Hello World prettier (#760) Fix #743 * Remove outdated Stetho documentation. * Fix Fresco docs link on the Image Style Props page (#783) * Remove CLI docs (#782) * Update scrollview.md to reflect duration argument (#115) * Update scrollview.md to reflect duration argument facebook/react-native#17422 adds the ability to control the duration of a scrollView animation, for Android only. * sync comments with ScrollView.js * add documentation about `.native.js` extensions (#346) * add documentation about `.native.js` extensions Lots of projects use the `.native.js` to share code between ReactJS and React Native (including core projects, like Jest) but there's no official documentation about it. I'm adding some info so projects can easily discover and refer to this feature. * fix comments and add pro-tip about `.native.js` Fixed the comment on a code block and added a pro-tip telling users to ignore `.native.js` extensions in their web bundlers in order to optimize final bundle size. * Update platform-specific-code.md * Link to all KeyboardType screenshots (#774) * Node version requirement made more prevalent (#775) Reading the first page of https://facebook.github.io/react-native/docs/getting-started.html, it is not clear that the node version needs to be 8+. Just adding this here to help others with installation, specially those of us who already have node running and need to upgrade. * Explicitly state that `activeOpacity` requires `underlayColor` (#781) * Explicitly state that `activeOpacity` requires `underlayColor` It's clear from facebook/react-native#11834 that the underlying issue won't be fixed, so we should update the documentation so people understand that for `activeOpacity` to work, they need to set `underlayColor`. * Update touchablehighlight.md * Add section : Known Issues with fetch and [..] (#769) * Add section : Known Issues with fetch and [..] Cookie based authentication is currently wobbly. Had it not been for the problematic redirect scenario using fetch workarounds could be found (e.g clearing cookies before every single request and manually adding them to the headers). However, because of the 302 issue there is a scenario where using cookies can result in halt of development. The rest of the issues are merely added here so that people that can follow workarounds ( please take a look as unintended consequences might occur ) * Minor text changes and remove the last paragraph. * Document how to publish custom React Native version (#675) * Add section for how to make a git dependency branch (#653) * move publishing a fork to separate page (#653) * updated review comments * link back from building android sources and updated docker link * changed to —force instead of changing .gitignore * Update publishing.md * Update correct signing information for iOS (#766) Ran into this problem while following this guide verbatim. * Update Wix link and title in showcast.json (#763) * change showcast wix logo app * fix file name * Update Wix link and title in showcast * Change wording to improve sentence (#759) * Text/TextInput: Android now supports `maxFontSizeMultiplier` prop (#755) Introduced by this commit: facebook/react-native@4936d28 * Fix typo (#738) * Fix typo * Update linking-libraries-ios.md * update to rn-diff-purge (#761) * Prettify * Sync guides
|
Was this released? It doesnt seem to work in Android when I get the react-native from 'https://github.com/expo/react-native/archive/sdk-36.0.0.tar.gz'. I checked the ReactScrollViewCommandHelper(I am assumimg this is where the changes happened) and there is no duration variable available yet. Am I missing something here? I am verifying my changes in an Android emulator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facebook/react-native#17422 adds the ability to control the duration of a scrollView animation, for Android only.
#17422