Skip to content

Commit

Permalink
Update hermes.md to include RN compatibility (#2361)
Browse files Browse the repository at this point in the history
* Update hermes.md to include RN compatibility

Hermes works more reliably following the versions explicitly documented in its releases page.

This is suggested by the community at facebook/hermes#33 (comment)

* port the addition to the base docs

Co-authored-by: Bartosz Kaszubowski <[email protected]>
  • Loading branch information
Huxpro and Simek authored Dec 4, 2020
1 parent 3c72887 commit 48e2417
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docs/hermes.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ First, ensure you're using at least version 0.60.4 of React Native.

If you have an existing app based on an earlier version of React Native, you will have to upgrade it first. See [Upgrading to new React Native Versions](/docs/upgrading) for how to do this. Make especially sure that all changes to `android/app/build.gradle` have been applied, as detailed by the [React Native upgrade helper](https://react-native-community.github.io/upgrade-helper/?from=0.59.0). After upgrading the app, make sure everything works before trying to switch to Hermes.

> ## Note for RN compatibility.
>
> Each Hermes release is aimed at a specific RN version. The rule of thumb is to always follow [Hermes releases](https://github.com/facebook/hermes/releases) strictly. Version mismatch can result in instant crash of your apps in the worst case scenario.
> ## Note for Windows users.
>
> Hermes requires [Microsoft Visual C++ 2015 Redistributable](https://www.microsoft.com/en-us/download/details.aspx?id=48145)
Expand Down
4 changes: 4 additions & 0 deletions website/versioned_docs/version-0.63/hermes.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ First, ensure you're using at least version 0.60.4 of React Native.

If you have an existing app based on an earlier version of React Native, you will have to upgrade it first. See [Upgrading to new React Native Versions](/docs/upgrading) for how to do this. Make especially sure that all changes to `android/app/build.gradle` have been applied, as detailed by the [React Native upgrade helper](https://react-native-community.github.io/upgrade-helper/?from=0.59.0). After upgrading the app, make sure everything works before trying to switch to Hermes.

> ## Note for RN compatibility.
>
> Each Hermes release is aimed at a specific RN version. The rule of thumb is to always follow [Hermes releases](https://github.com/facebook/hermes/releases) strictly. Version mismatch can result in instant crash of your apps in the worst case scenario.
> ## Note for Windows users.
>
> Hermes requires [Microsoft Visual C++ 2015 Redistributable](https://www.microsoft.com/en-us/download/details.aspx?id=48145)
Expand Down

0 comments on commit 48e2417

Please sign in to comment.