New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fixing github build: install only opam with apt #893

Closed

stroxler wants to merge 1 commit into main from export-D59591828

Contributor

stroxler commented Jul 10, 2024

Summary:
The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting dune from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Jul 10, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

facebook-github-bot added the fb-exported label

stroxler added a commit that referenced this pull request


          Try fixing github build: install only opam with apt (#893)

815e010

Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

stroxler force-pushed the export-D59591828 branch from 419e7c2 to 815e010 Compare

July 10, 2024 18:05

Contributor

facebook-github-bot commented Jul 10, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

1 similar comment

Contributor

facebook-github-bot commented Jul 10, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request


          Try fixing github build: install only opam with apt (#893)

eba4156

Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

stroxler force-pushed the export-D59591828 branch from 815e010 to eba4156 Compare

July 10, 2024 18:32

Contributor

facebook-github-bot commented Jul 10, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request


          Try fixing github build: install only opam with apt (#893)

fb3fe6b

Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

stroxler force-pushed the export-D59591828 branch from eba4156 to fb3fe6b Compare

July 10, 2024 19:12

Contributor

facebook-github-bot commented Jul 10, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request


          Try fixing github build: install only opam with apt (#893)

c312f7b

Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

stroxler force-pushed the export-D59591828 branch from fb3fe6b to c312f7b Compare

July 10, 2024 19:58

Contributor

facebook-github-bot commented Jul 10, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request


          Try fixing github build: install only opam with apt (#893)

4653c3b

Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

stroxler force-pushed the export-D59591828 branch from c312f7b to 4653c3b Compare

July 10, 2024 20:33

Contributor

facebook-github-bot commented Jul 12, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request


          Try fixing github build: install only opam with apt (#893)

5976e46

Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

stroxler force-pushed the export-D59591828 branch from 4653c3b to 5976e46 Compare

July 12, 2024 16:34


          Try fixing github build: install only opam with apt (#893)

e5dfc0b

Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

Contributor

facebook-github-bot commented Jul 12, 2024

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler force-pushed the export-D59591828 branch from 5976e46 to e5dfc0b Compare

July 12, 2024 16:40

Contributor Author

stroxler commented Jul 12, 2024

I'm going to leave this up for now... the latest results seem to show that setup.py's PATH is somehow not making it all the way into the makefile logic behind make dev.

See these logs:
https://github.com/facebook/pyre-check/actions/runs/9911237956/job/27383440089?pr=893

It's pretty easy to see the path logged out from setup.py does not match what the Makefile sees, and this is why the Makefile can't find dune.

I'm pretty stumped about why; I know for sure that environment variables set at the top level do make it.

stroxler closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment