Optimize

[noscripter]

• [x] extract process.env.NODE_ENV
• more intuitive createChainableTypeChecker condition
• use loose-envify as a devDependency

[TrySound]

@noscripter NODE_ENV is replaced statically with bundler for browsers. It should not be extracted.

[noscripter]

@noscripter NODE_ENV is replaced statically with bundler for browsers. It should not be extracted.

Thanks for that info, can you provide more detail for me to dive into?

[TrySound]

This convention is shared across many packages (especially react ones)
https://github.com/rollup/rollup-plugin-replace
https://webpack.js.org/guides/production/#specify-the-mode

[noscripter]

This convention is shared across many packages (especially react ones)
https://github.com/rollup/rollup-plugin-replace
https://webpack.js.org/guides/production/#specify-the-mode

Coool, thanks.

[ljharb]

why is this a better change? == null is more reliable, since undefined can be redefined.

[noscripter]

why is this a better change? == null is more reliable, since undefined can be redefined.

Thanks @ljharb I found this question on stackoverflow, it looks like a problem related to legacy browsers only, but your review did make sense.

[noscripter]

Also according to MDN, undefined should be un-writable but it's not a reserved word, so in some context it may be redefined as well.

(function() { var undefined = 'foo'; console.log(undefined, typeof undefined); })();

[ljharb]

this must be a runtime dependency, otherwise #203 (comment) breaks people.

[noscripter]

this must be a runtime dependency, otherwise #203 (comment) breaks people.

Got it, I thought it was only used for build in the first place.