fw_upgrade: fix 'occured' -> 'occurred' in upgrade log/error messages#264
Closed
SAY-5 wants to merge 2 commits intofacebook:heliumfrom
Closed
fw_upgrade: fix 'occured' -> 'occurred' in upgrade log/error messages#264SAY-5 wants to merge 2 commits intofacebook:heliumfrom
SAY-5 wants to merge 2 commits intofacebook:heliumfrom
Conversation
Four log/error messages in tools/fw_upgrade/entity_upgrader.py and one in tests2/common/base_fw_upgrade_test.py read 'occured'. User-visible in upgrade logs. Fixed to 'occurred'. String-literal-only change. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D101227204. (Because this pull request was imported automatically, there will not be any future comments.) |
Author
|
Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, hashicorp/hcl#794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five log/error messages across two firmware upgrade files read
occured:tools/fw_upgrade/entity_upgrader.pytests2/common/base_fw_upgrade_test.pyFixed to
occurred. String-literal-only change — visible in firmware upgrade output logs.