Make ocamlpool compile with OCaml 5#10
Closed
shayne-fletcher wants to merge 1 commit intofacebook:ocaml-5.0from
Closed
Make ocamlpool compile with OCaml 5#10shayne-fletcher wants to merge 1 commit intofacebook:ocaml-5.0from
shayne-fletcher wants to merge 1 commit intofacebook:ocaml-5.0from
Conversation
!! This is super hacky !! This code used CAML_INTERNALS which understandably broke in OCaml 5. The new code is modeled after OCaml 5.0's intern.c. This is just for experimentation, and should not be merged with trunk.
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
Summary: Pull Request resolved: facebook/buck2-shims-meta#10 Reviewed By: sdwilsh Differential Revision: D77232708 Pulled By: bigfootjon fbshipit-source-id: 590a758856fbaf1d570df8c9161dd6c4c4123e96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! This is super hacky !!
This code used CAML_INTERNALS which understandably broke in OCaml 5. The new code is modeled after OCaml 5.0's intern.c.
This is just for experimentation, and should not be merged with trunk.