Skip to content

Fix build with Boost 1.89.0 #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cho-m wants to merge 1 commit into from
Closed

Fix build with Boost 1.89.0 #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,21 @@ fb_activate_static_library_option()
set(QUIC_FBCODE_ROOT ${CMAKE_CURRENT_SOURCE_DIR})

# Dependencies
find_package(Boost 1.62
REQUIRED COMPONENTS
set(MVFST_BOOST_COMPONENTS
iostreams
system
thread
filesystem
regex
context
date_time
program_options
)
find_package(Boost 1.62 REQUIRED COMPONENTS ${MVFST_BOOST_COMPONENTS})
if (Boost_MAJOR_VERSION EQUAL 1 AND Boost_MINOR_VERSION LESS 69)
list(APPEND MVFST_BOOST_COMPONENTS system)
find_package(Boost 1.62 REQUIRED COMPONENTS ${MVFST_BOOST_COMPONENTS})
endif()
string(REPLACE ";" " " MVFST_BOOST_COMPONENTS "${MVFST_BOOST_COMPONENTS}")
find_package(fmt REQUIRED)
find_package(folly REQUIRED)
find_package(Fizz REQUIRED)
Expand Down
2 changes: 1 addition & 1 deletion cmake/mvfst-config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ include(CMakeFindDependencyMacro)
find_dependency(folly)
find_dependency(Fizz)
find_dependency(Threads)
find_dependency(Boost COMPONENTS iostreams system thread filesystem regex context)
find_dependency(Boost COMPONENTS @MVFST_BOOST_COMPONENTS@)

if(NOT TARGET mvfst::mvfst_transport)
include("${CMAKE_CURRENT_LIST_DIR}/mvfst-targets.cmake")
Expand Down