[sample] Remove Flipper integration temporarily #985
Closed
+1
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passy
force-pushed
the
pr985
branch
2 times, most recently
from
1256fa8 to
11ffd62
Compare
passy
force-pushed
the
pr985
branch
2 times, most recently
from
8359a50 to
c1d149f
Compare
passy
force-pushed
the
pr985
branch
2 times, most recently
from
6749711 to
8c3c683
Compare
passy
force-pushed
the
pr985
branch
2 times, most recently
from
787fb04 to
a3f1957
Compare
Closed
Contributor
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@passy has updated the pull request. You must reimport the pull request before landing. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Summary:
The tests are not actually being run.
After upgrading the Gradle plugin on GitHub, it has become clear that these are running without the AP processing them. When processed, they raise some fairly obvious mistakes:
{P1221730610}
This is removing them for now so we can get the update and new release out.
Done using
```
pastry P1221730610 | rg -F '/src/' | awk '{print $1}' | cut -d ':' -f 1 | uniq | sed -e 's:/Users/realpassy/Projects/java/litho/::' | xargs hg rm -v
```
To restore the rests, let's do it one-by-one by doing `hg revert -r 5ac836c8ff21bb798ce1aba47a47857f93f3d47c^ -- litho-it/path/to/test.java`
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/litho/pull/988).
* #986
* #985
* __->__ #988
Pull Request resolved: #988
Reviewed By: adityasharat
Differential Revision: D58789067
Pulled By: passy
fbshipit-source-id: fb1aacd92dc88e0fb4d7ad4dc4c918396958fc3f
Contributor
|
@passy has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
passy
added a commit
that referenced
this pull request
Jul 17, 2024
Original commit changeset: 90df873
passy
added a commit
that referenced
this pull request
Jul 18, 2024
Original commit changeset: 90df873
passy
added a commit
that referenced
this pull request
Jul 18, 2024
Original commit changeset: 90df873
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.