Add @LooperMode LEGACY in tests that fail in PAUSED mode #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Robolectric PAUSED LooperMode will become the default in new versions of Robolectric. We have ran all tests against the new PAUSED LooperMode and unfortunately some tests are failing. For these tests we need to explicitly specify the LooperMode as LEGACY to be future proof, so that they do not start failing when the default changes to PAUSED in the future.
|
Hi team, just wanted to check whether you had any feedback on this PR. Thanks! |
There was a problem hiding this comment.
@colriot has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new Robolectric PAUSED LooperMode will become the default in new versions of
Robolectric. We have ran all litho-it tests against the new PAUSED LooperMode and
unfortunately some of them are failing. For these tests we need to explicitly specify the
LooperMode as LEGACY to be future proof, so that they do not start failing when the
default changes to PAUSED in the future.
Changelog
Add @LooperMode LEGACY in tests that fail in PAUSED LooperMode
Test Plan
N/A, this change only affects tests