Upgrade Litho tests to Robolectric 3.8 #632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19949477 |
Summary: On Jan 15, 2020 Maven doesn't support unsecure HTTP communication. More context: https://support.sonatype.com/hc/en-us/articles/360041287334-Central-501-HTTPS-Required As a consequence this fails the build on CI when Robolectric tries to fetch its deps via 'http://repo1.maven.org/maven2'. This diff uses Robolectric's system prop to override default repo url. Differential Revision: D19949460 fbshipit-source-id: 8156ec93546d6df782394851fb3f12dda1de5ffa
Summary: Pull Request resolved: facebook#632 To support `robolectric.dependency.repo.url` prop for overriding Maven Repo (to fix Circle CI) we need Robolectric of version 3.1+. Differential Revision: D19949477 fbshipit-source-id: a8aa2b9cbf773e98e72bb6624ab9f00046dc0d18
colriot
force-pushed
the
export-D19949477
branch
from
d7347c7 to
7a493d5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19949477 |
Contributor
|
Just go to 4.3! |
Contributor
Author
|
@vinc3m1 I wish it would be so easy :) But step by step... progress is inevitable! |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To support
robolectric.dependency.repo.urlprop for overriding Maven Repo (to fix Circle CI) we need Robolectric of version 3.1+.Differential Revision: D19949477