Skip to content

Back out "Remove Flipper integration temporarily (#985)" #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
passy wants to merge 1 commit into from
Closed

Back out "Remove Flipper integration temporarily (#985)" #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sample/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ dependencies {
implementation project(':litho-core')
implementation project(':litho-coroutines-kotlin')
implementation project(':litho-editor-core')
implementation(project(':litho-editor-flipper')) {
exclude group:'com.facebook.flipper'
}
implementation project(':litho-fresco')
implementation project(':litho-fresco-kotlin')
implementation project(':litho-live-data')
Expand All @@ -59,6 +62,10 @@ dependencies {

// First-party
implementation deps.soloader
implementation deps.flipper
implementation(deps.flipperLithoPlugin) {
exclude group:'com.facebook.litho'
}
implementation deps.fresco
implementation deps.frescoVito
implementation deps.frescoVitoLitho
Expand Down
24 changes: 24 additions & 0 deletions sample/src/main/java/com/facebook/samples/litho/LithoSampleApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,17 @@

import android.app.Application;
import com.facebook.drawee.backends.pipeline.Fresco;
import com.facebook.flipper.android.AndroidFlipperClient;
import com.facebook.flipper.android.utils.FlipperUtils;
import com.facebook.flipper.core.FlipperClient;
import com.facebook.flipper.plugins.inspector.DescriptorMapping;
import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin;
import com.facebook.flipper.plugins.sections.SectionsFlipperPlugin;
import com.facebook.flipper.plugins.uidebugger.UIDebuggerFlipperPlugin;
import com.facebook.flipper.plugins.uidebugger.core.UIDContext;
import com.facebook.flipper.plugins.uidebugger.litho.UIDebuggerLithoSupport;
import com.facebook.fresco.vito.init.FrescoVito;
import com.facebook.litho.editor.flipper.LithoFlipperDescriptors;
import com.facebook.rendercore.debug.DebugEventBus;
import com.facebook.rendercore.debug.DebugEventLogger;
import com.facebook.soloader.SoLoader;
Expand All @@ -34,5 +44,19 @@ public void onCreate() {
Fresco.initialize(this);
FrescoVito.initialize();
SoLoader.init(this, false);

if (FlipperUtils.shouldEnableFlipper(this)) {
final FlipperClient client = AndroidFlipperClient.getInstance(this);

UIDContext uiDebuggerContext = UIDContext.Companion.create(this);
UIDebuggerLithoSupport.INSTANCE.enable(uiDebuggerContext);
client.addPlugin(new UIDebuggerFlipperPlugin(uiDebuggerContext));

final DescriptorMapping descriptorMapping = DescriptorMapping.withDefaults();
LithoFlipperDescriptors.add(descriptorMapping);
client.addPlugin(new InspectorFlipperPlugin(this, descriptorMapping));
client.addPlugin(new SectionsFlipperPlugin(true));
client.start();
}
}
}