[lexical][lexical-table] Bug Fix: Allow TableSelection to be preserved during contextmenu events #6964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LexicalEvents traps all pointerdown events to update the selection later on pointerup, but it doesn't check for the button so this also updates selection on contextmenu events.
Also refactors a lot of our DOM guards to consistently use functions like
isHTMLElement
or the newisDOMNode
rather than usinginstanceof
(not compatible with frames) or casts (unsafe). These functions now acceptunknown
rather than a specific type such asEventType
orNode
for ease of use without any real loss of safety.Closes #6941
Test plan
Before
playground url
lexical-table-selection-contextmenu-before.mov
After
PR playground url
lexical-table-selection-contextmenu-after.mov