Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Chore: Update Prettier to v3 #6920

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

daichan132
Copy link
Contributor

@daichan132 daichan132 commented Dec 8, 2024

Description

  • Current behavior: The codebase uses synchronous prettier.format calls compatible with Prettier v2.

  • Changes introduced:

    • Upgraded Prettier from ^2.3.2 to ^3.4.2.
    • Updated all usages of prettier.format to handle its new asynchronous behavior in Prettier v3.
    • Adjusted the handling of Prettier plugins and parsers in PrettierButton to ensure compatibility with Prettier v3, including dynamic imports and necessary adaptations.

These changes update the lexical-playground package to be fully compatible with the API changes in Prettier v3.

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 8:03am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 8:03am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

size-limit report 📦

Path Size
lexical - cjs 31.11 KB (0%)
lexical - esm 30.98 KB (0%)
@lexical/rich-text - cjs 40.11 KB (0%)
@lexical/rich-text - esm 32.8 KB (0%)
@lexical/plain-text - cjs 38.68 KB (0%)
@lexical/plain-text - esm 30.11 KB (0%)
@lexical/react - cjs 42 KB (0%)
@lexical/react - esm 34.15 KB (0%)

@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Dec 8, 2024
@etrepum etrepum added this pull request to the merge queue Dec 8, 2024
Merged via the queue into facebook:main with commit 05fa244 Dec 8, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants