-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical][lexical-playground] Bug Fix: Allow setEditorState to work correctly inside of an update #6876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 27, 2024
size-limit report 📦
|
etrepum
changed the title
[lexical][lexical-history][lexical-playground] Bug Fix: Allow setEditorState to work correctly inside of an update
[lexical][lexical-playground] Bug Fix: Allow setEditorState to work correctly inside of an update
Nov 27, 2024
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
November 28, 2024 07:20
potatowagon
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LexicalEditor.setEditorState has a bunch of shared code with LexicalEditor.update such that it doesn't need to be issued from inside of an update. However, if it is issued inside of an update then it will cause an extra
$commitPendingUpdates
call after the state and selection are already read-only which will throw in some situations when node transforms are in use.This fix ensures that setEditorState is working with a writable state and selection so that transforms can run, and skips the redundant
$commitPendingUpdates
call for the scenarios when it is being called from inside an existing update context (e.g. a dispatchCommand from the history plugin)Closes #6843
Test plan
Before
autocomplete-undo.mov
After
autocomplete-undo-after.mov