Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] Bug Fix: Use local excalidraw #6861

Closed
wants to merge 4 commits into from
Closed

[lexical-playground] Bug Fix: Use local excalidraw #6861

wants to merge 4 commits into from
+128 −3

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Nov 23, 2024 •
edited
Loading

Description

Excalidraw is configured by default to load its assets from a public CDN (unpkg). This adds additional latency to local development and the test suite, particularly when working with an unstable connection.

Removing this third party connection should also speed up our CI and make it slightly more reliable.

I can thank the current atmospheric river in SF combined with wireless internet to tracking this one down 🌧️

Test plan

Before

Open network inspector to find assets loaded from unpkg.com in the playground

Screenshot 2024-11-22 at 18 15 38

After

No assets loaded from unpkg.com in the playground build for this PR

Screenshot 2024-11-22 at 18 32 47

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 3:07am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 3:07am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 30.94 KB (0%)
lexical - esm 30.8 KB (0%)
@lexical/rich-text - cjs 39.6 KB (0%)
@lexical/rich-text - esm 32.66 KB (0%)
@lexical/plain-text - cjs 38.2 KB (0%)
@lexical/plain-text - esm 29.92 KB (0%)
@lexical/react - cjs 41.37 KB (0%)
@lexical/react - esm 34 KB (0%)

@etrepum etrepum marked this pull request as ready for review November 23, 2024 02:33
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Nov 23, 2024
@etrepum etrepum mentioned this pull request Nov 23, 2024
Merged
@etrepum etrepum deleted the copy-excalidraw-assets branch November 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etrepum @facebook-github-bot