[lexical-rich-text][lexical-plain-text] workaround for Korean IME issue on iOS #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2wheeh
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
Co-authored-by: wnhlee <[email protected]>
2wheeh
force-pushed
the
fix/no-side-effect-ios-korean-workaround
branch
from
33ba318 to
e317974
Compare
etrepum
previously approved these changes
Nov 12, 2024
There was a problem hiding this comment.
This seems pretty low risk given the isolation to just iOS+Korean, I don't have any experience with IMEs so I can't really provide any guidance for what a proper fix would be and I am not even sure I could test it very easily (I couldn't get the korean IME to work in the iOS simulator, it never combines characters for me, and on my phone I don't think it would be very easy for me to have navigator.langauge set to korean)
Co-authored-by: Bob Ippolito <[email protected]>
etrepum
approved these changes
Nov 12, 2024
|
The only failing tests is a very flaky one (that is improved in #6759) so I'm going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related to #5841, #3305.
based on #4814,
isCollapsedhandling.while we don't have
e2e-iostests, I checked the fix withoutif (navigator.language === 'ko-KR' && IS_IOS)passed tests on my local.please include @DeadIntegral as a co-author since it contains his work.
Closes #4814
Test plan
Before
ScreenRecording_11-13-2024.00-51-43_1.mov
After
ScreenRecording_11-13-2024.00-48-57_1.MOV