-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-website] Chore: upgrade to Docusaurus v3.6 - Docusaurus Faster #6761
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let you know once it's safe to review/merge
For now, I mostly needed a v3 site to test the upcoming faster features. I don't have access to the facebook preset source code so the goal was to test what changes I should advise the preset devs to do to add proper support.
@@ -0,0 +1,31 @@ | |||
diff --git a/packages/lexical-website/node_modules/docusaurus-plugin-internaldocs-fb/index.js b/packages/lexical-website/node_modules/docusaurus-plugin-internaldocs-fb/index.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporay patch, until the fb preset adds support for Rspack in an upcoming release
Docusaurus v3.6 is out: https://docusaurus.io/blog/releases/3.6 I'll let @antonk52 or @jknoxville follow up on the internal FB preset support for Rspack. |
@slorber I've just released [email protected] that should work with rspack. the patch should no longer be needed |
Great, it's working 👍 Just did the PR cleanup, ready to review! This command works well locally but I can't access Vercel logs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you
@slorber I did notice that docusaurus-plugin-internaldocs-fb has an implicit dependency on mercurial (
It seems to work just fine, could probably be "fixed" by redirecting that output to nowhere. |
I don't recall this stderr output, but the last time I worked on the docs build was a while ago. |
The problem isn't so much that there are hg calls, it's that their exceptions are being ignored without capturing stderr |
These have been there for the past 2~2.5 years. I do agree that we should update it to only make these calls when inside a mercurial project. I can try to do this, but that would be no sooner than next week. |
Description
Upgrade Docusaurus to v3.6 (upcoming, WIP)
Enable the Docusaurus Faster options.
The site now bundles in 7 seconds instead of 50 seconds.
(However the doc gen phase remains slow)
Test plan
??? local or preview?
Before
After