Bug Fix: Shift+down selects an extra subsequent element for Table selection #6679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatsiarynaDzibrova
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
ivailop7
reviewed
Oct 1, 2024
| focusNode, | ||
| (n) => $isElementNode(n) && !n.isInline(), | ||
| ); | ||
| if ($isTableCellNode(focusParentNode)) { | ||
| focusParentNode = getParentTable(focusParentNode); |
There was a problem hiding this comment.
why not just $findMatchingParent(focusParentNode, $isTableNode), but needing that extra helper method, it will return the table node or null, just like your method.
Cursor should stop inside first/last cell of table not on the paragraph before/after the table
| focusOffset: 0, | ||
| focusPath: [2], | ||
| focusOffset: 1, | ||
| focusPath: [1, 2, 1], |
There was a problem hiding this comment.
Focus will now be inside the last cell of the table, not on the next element after table
etrepum
reviewed
Oct 13, 2024
There was a problem hiding this comment.
It still seems possible to get "stuck" if you remove any elements between the tables
For example, using this document with two tables and a paragraph, if you focus the last paragraph and then press shift up it works to select the first table but not the second
the third part takes care of changing selection already. This part also has a bug: the case of selecting table using shift+up (not down) is not handled which makes selection stuck
|
Addressed your comment in 0a47177 |
etrepum
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only the table should be selected when shift+down. Also fixes scenario when selection is stuck when trying to unselect a table with arrow keys.
Closes #6527 for Tables
Test plan
Before
Paragraph after table is selected
After
Only table is selected
Before
Selection stuck
After
Can unselect tables one by one
