-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-markdown] set shouldMergeAdjacentLines default to be false #6660
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
hi @GermanJablo please set |
I wonder if it might be better to use a single prop like "GFM | Commonmark". Right now, it's just one prop, but in the future, there could be many more for people targeting different specs. I don't think users will want to figure out the right combination of props to match their target spec. For instance, when using MDX, you typically rely on plugins that handle different converters for each spec. |
an enum for that would be nice, but likely would have to create a new api for that and mark the old one as deprecated, for backwards compatibilty. perhaps in a future PR. also would have to brainstorm what other flavours and variations there could be and how best to groupd them. labelling this behavior as GFM would need more research as there could be differences we dont know yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should bias towards backwards compatibility here
Description
For backwards compatibility, setting default shouldMergeAdjacentLines = false to not introduce breaking change from the previous npm release.
Github Flavoured Markdown has the same behavior as shouldMergeAdjacentLines = false:
Screen.Recording.2024-09-24.at.2.19.03.PM.mov
Test plan
npm run test-unit
npm run test-e2e-chromium