Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Bug Fix: empty code block not focused #6649

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

potatowagon
Copy link
Contributor

Description

when converting an empty editor to markdown codeblock, the codeblock isnt focused and typing puts chars into the editor root instead of the codeblock. does not happen if codeblock is not empty

Test plan

Before

Screen.Recording.2024-09-20.at.12.58.35.AM.mov

After

Screen.Recording.2024-09-20.at.12.59.04.AM.mov

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:05am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:05am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

size-limit report 📦

Path Size
lexical - cjs 29.85 KB (0%)
lexical - esm 29.66 KB (0%)
@lexical/rich-text - cjs 38.3 KB (0%)
@lexical/rich-text - esm 31.55 KB (0%)
@lexical/plain-text - cjs 36.9 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.04 KB (0%)
@lexical/react - esm 32.91 KB (0%)

@potatowagon potatowagon added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit db6454f Sep 20, 2024
11 checks passed
@potatowagon potatowagon deleted the fix-md-c branch September 20, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants