Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-react][lexical-playground] Bug Fix: Workaround for yjs disconnect race in React StrictMode #6644

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Sep 19, 2024

Description

The PR in #6619 created a regression for local collab development by introducing a timing change in when disconnect was called. When reviewing the PR I didn't think it caused an issue because the deployed playground and CI tests worked fine, but when running the playground locally with vite dev mode it does cause an issue.

#6619 (comment)

Closes #6640

Test plan

Before

npm run start
npm run test-e2e-chromium # from another terminal

All tests fail.

Can also reproduce collab not working at http://localhost:3000/split/?isCollab=true

Note that this only happens when running locally with vite dev, it does not cause any problems in CI or in production.

After

It all works as expected.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 1:10am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 1:10am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2024
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Sep 19, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.85 KB (0%)
lexical - esm 29.66 KB (0%)
@lexical/rich-text - cjs 38.3 KB (+0.07% 🔺)
@lexical/rich-text - esm 31.55 KB (0%)
@lexical/plain-text - cjs 36.9 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.04 KB (0%)
@lexical/react - esm 32.91 KB (0%)

Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@etrepum etrepum added this pull request to the merge queue Sep 19, 2024
Merged via the queue into facebook:main with commit deb5894 Sep 19, 2024
43 checks passed
@zurfyx
Copy link
Member

zurfyx commented Sep 19, 2024

Thank you Bob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Collab not connecting in dev mode
4 participants