address micromatch vulnerability #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
acywatson
reviewed
Sep 10, 2024
package.json
Outdated
| @@ -188,6 +188,7 @@ | |||
| "vite": "^5.2.11" | |||
| }, | |||
| "dependencies": { | |||
| "micromatch": "^4.0.8", | |||
There was a problem hiding this comment.
Why are we adding this dep to the monorepo package.json?
There was a problem hiding this comment.
hmm yea perhaps i installed in the wrong page path
There was a problem hiding this comment.
oh i saw wrongly, micromatch is a downstream dependency of a few installed dependencies. will figure a way to update correctly
There was a problem hiding this comment.
ran npm update micromatch (prev i ran the wrong cmd)
potatowagon
force-pushed
the
micromatch
branch
from
6739f22
to
ba7c3c6
Compare
potatowagon
force-pushed
the
micromatch
branch
from
ba7c3c6
to
f7211e2
Compare
abhijitt
approved these changes
Sep 11, 2024
freddymeta
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/advisories/GHSA-952p-6rrq-rcjv?fbclid=IwZXh0bgNhZW0CMTEAAR1-F3hq4wRW-qOIChOFDGEzEyBnb8xYVe6tgWjuAzkJUZSwTvlR8d7NjuA_aem_miRrWL4kXpjCaEqbmreXgA
update to version 4.0.8 to address vulnerabliity
ran
npm update micromatchTest plan
see automated tests