Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Fix: Poll Option not clickable at some place after checked state #6609

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

iamvinayvk
Copy link
Contributor

Description

Poll option was not clickable after the checked state due to pseudo after element. Added pointer-events:none to let the events pass through the pseudo elements on checkbox change

Closes #6551

Test plan

Before

Insert relevant screenshots/recordings/automated-tests
https://d.pr/i/vHvKcU

After

Lexical.mp4

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 6:16pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 6:16pm

@facebook-github-bot
Copy link
Contributor

Hi @iamvinayvk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

github-actions bot commented Sep 7, 2024

size-limit report 📦

Path Size
lexical - cjs 29.66 KB (0%)
lexical - esm 29.48 KB (0%)
@lexical/rich-text - cjs 38.07 KB (0%)
@lexical/rich-text - esm 31.32 KB (0%)
@lexical/plain-text - cjs 36.65 KB (0%)
@lexical/plain-text - esm 28.66 KB (0%)
@lexical/react - cjs 39.83 KB (0%)
@lexical/react - esm 32.75 KB (0%)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 7, 2024
@etrepum etrepum added this pull request to the merge queue Sep 7, 2024
Merged via the queue into facebook:main with commit 7aec43d Sep 7, 2024
41 checks passed
@mdmuhtasimfuadfahim
Copy link

mdmuhtasimfuadfahim commented Sep 8, 2024

Thanks @iamvinayvk. This solve the issue.

@etrepum
Copy link
Collaborator

etrepum commented Sep 8, 2024

@iamvinayvk is the one to thank 🙌 , I just reviewed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The Poll component doesn't get checked / unchecked each time on click
4 participants