Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Bug Fix: fix comment timestamps #6555

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Aug 26, 2024

Description

When adding collaborative comments in the playground, the comment timestamps are now consistent even in different window contexts.

Closes #6554

Test plan

Follow the reproduction steps in issue #6554 and see that the comment timestamps are now the same.

Before

Comment timestamps are inconsistent in different window contexts.

After

Comment timestamps are the same in different window contexts.

Note

There are other uses of performance.now() in this repo that might need to be reviewed.

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 2:35am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 2:35am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.89 KB (0%)
@lexical/rich-text - esm 31.07 KB (0%)
@lexical/plain-text - cjs 36.49 KB (0%)
@lexical/plain-text - esm 28.41 KB (0%)
@lexical/react - cjs 39.61 KB (0%)
@lexical/react - esm 32.52 KB (0%)

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@etrepum
Copy link
Collaborator

etrepum commented Aug 26, 2024

I don't think that any of the other performance.now() calls are distributed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Playground comments have inconsistent timestamps in different window contexts
3 participants