Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-table] Fix a number of table Cut command scenarios #6528

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

ivailop7
Copy link
Collaborator

@ivailop7 ivailop7 commented Aug 19, 2024

Fixing a few Table Cut related issues:

  1. When selected text + table and table is last node, Cut results in incorrect remaining paragraph text
leaves_incorrect_text.mov
  1. When selected text + table and table is first node, Cut results in a table with single row and of single cell
cut_issue_when_first_cell.mov
  1. When selection is inside a table, cut doesn't clear the cell contents after copy-ing (Resolves: Bug: Cut from a table doesn't remove values #6402)

  2. When the whole table is selected, cut should truly cut the table, so the user can paste elsewhere.

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 4:31pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 4:31pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2024
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.74 KB (0%)
@lexical/rich-text - esm 31.05 KB (0%)
@lexical/plain-text - cjs 36.41 KB (0%)
@lexical/plain-text - esm 28.42 KB (0%)
@lexical/react - cjs 39.64 KB (0%)
@lexical/react - esm 32.51 KB (0%)

@ivailop7 ivailop7 changed the title Fix a number of table cut scenarios Fix a number of table Cut command scenarios Aug 19, 2024
@ivailop7 ivailop7 changed the title Fix a number of table Cut command scenarios [lexical-table] Fix a number of table Cut command scenarios Aug 21, 2024
@ivailop7 ivailop7 requested a review from etrepum August 21, 2024 10:41
@ivailop7
Copy link
Collaborator Author

@etrepum @zurfyx @potatowagon could I get a sign off here

etrepum
etrepum previously approved these changes Aug 21, 2024
packages/lexical-table/src/LexicalTableSelectionHelpers.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cut from a table doesn't remove values
3 participants