-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-table] Fix a number of table Cut command scenarios #6528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 19, 2024
size-limit report 📦
|
ivailop7
changed the title
Fix a number of table cut scenarios
Fix a number of table Cut command scenarios
Aug 19, 2024
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson and
Fetz
as code owners
August 21, 2024 09:26
ivailop7
changed the title
Fix a number of table Cut command scenarios
[lexical-table] Fix a number of table Cut command scenarios
Aug 21, 2024
@etrepum @zurfyx @potatowagon could I get a sign off here |
etrepum
previously approved these changes
Aug 21, 2024
etrepum
approved these changes
Aug 22, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few Table Cut related issues:
leaves_incorrect_text.mov
cut_issue_when_first_cell.mov
When selection is inside a table, cut doesn't clear the cell contents after copy-ing (Resolves: Bug: Cut from a table doesn't remove values #6402)
When the whole table is selected, cut should truly cut the table, so the user can paste elsewhere.