Object.freeze nodes after reconciliation #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjbainbridge
approved these changes
Sep 24, 2021
facebook-github-bot
added
the
CLA Signed
acywatson
pushed a commit
that referenced
this pull request
Apr 9, 2022
* Object.freeze nodes after reconcilation * Move Object.freeze to better locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make it harder to accidently mutates a node's properties when that node has already been reconciled. The correct pattern is to call
this.getWritable()and to write to that (thus invoking the cloning logic). So we can make it a bit harder in DEV mode by callingObject.freeze()on the node after we've reconciled said node.