Multiple update tags #6507
Merged
Multiple update tags #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
|
FWIW there is |
acywatson
reviewed
Aug 12, 2024
| @@ -219,6 +219,20 @@ function $normalizeAllDirtyTextNodes( | |||
| } | |||
| } | |||
|
|
|||
| function addTags(editor: LexicalEditor, tags: undefined | string | string[]) { | |||
| if (!tags) { | |||
acywatson
approved these changes
Aug 12, 2024
etrepum
approved these changes
Aug 22, 2024
| @@ -219,6 +219,20 @@ function $normalizeAllDirtyTextNodes( | |||
| } | |||
| } | |||
|
|
|||
| function addTags(editor: LexicalEditor, tags: undefined | string | string[]) { | |||
| if (!tags) { | |||
There was a problem hiding this comment.
Suggested change
| if (!tags) { | |
| if (tags === undefined || tags.length === 0) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
history-mergebeing a sort of imposed tag to follow certain behavior, you're forced to trigger anothereditor.updateto pass your own tag. This is a patchy workaround. What's more, this workaround doesn't work fordiscreteupdates.This diff adds support for an array of tags, I kept the
tagname singular for backward compatibility.