[lexical-rich-text] Bug Fix: HeadingNode.insertNewAfter #6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
|
Before and After: https://www.loom.com/share/522f8f3bd808464bb07c7019c3abdf36 |
|
i can reproduce the issue, had to create multiple text nodes in heading, eg. bold "Hello" in "Hello world" |
potatowagon
reviewed
Jul 24, 2024
| headingNode = new HeadingNode('h1'); | ||
| const headingTextNode1 = $createTextNode('hello'); | ||
| const headingTextNode2 = $createTextNode(' world'); | ||
| headingTextNode2.setFormat('bold'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a paragraph is inserted when the selection is at the end of a heading, a paragraph should be inserted.
However, the logic for detecting whether the selection was at the end of the heading was incorrect. It did not work if, for example, the heading had multiple TextNodes.