Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-table] Bug Fix: cannot delete content when a table inside selection #6412

Merged
merged 3 commits into from
Jul 28, 2024
+25 −7
Merged

[lexical-table] Bug Fix: cannot delete content when a table inside selection #6412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
754a200
Bug Fix: cannot delete content when a table inside selection
placeba Jul 17, 2024
b26ce5a
Merge pull request #1 from facebook/main
placeba Jul 25, 2024
ff7b59f
Clean up extra selections
ivailop7 Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/lexical-playground/__tests__/e2e/Tables.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,6 +1245,30 @@ test.describe.parallel('Tables', () => {
);
});

test('Can delete all with node selection', async ({
page,
isCollab,
isPlainText,
}) => {
await initialize({isCollab, page});
test.skip(isPlainText);
await focusEditor(page);
await page.keyboard.type('Text before');
await page.keyboard.press('Enter');
await insertSampleImage(page);
await page.keyboard.press('Enter');
await page.keyboard.type('Text after');
await insertTable(page, 2, 3);
await selectAll(page);
await page.keyboard.press('Backspace');
await assertHTML(
page,
html`
<p class="PlaygroundEditorTheme__paragraph"><br /></p>
`,
);
});

test(`Horizontal rule inside cell`, async ({page, isPlainText, isCollab}) => {
await initialize({isCollab, page});
test.skip(isPlainText);
Expand Down
8 changes: 1 addition & 7 deletions packages/lexical-table/src/LexicalTableSelectionHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,16 +329,10 @@ export function applyTableHandlers(
if (!parentNode) {
return false;
}
const nextNode = table.getNextSibling() || table.getPreviousSibling();
table.remove();
if (nextNode) {
nextNode.selectStart();
} else {
parentNode.selectStart();
}
}
}
return true;
return false;
}

if ($isTableSelection(selection)) {
Expand Down
Loading