Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ref to contenteditable #6381

Merged
merged 15 commits into from
Jul 15, 2024
Merged

Add ref to contenteditable #6381

merged 15 commits into from
Jul 15, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Jul 8, 2024 •
edited
Loading

For some reason we ended up with a custom version of LexicalContentEditable in some internal places. There are some minor differences: role, ref and the need for an editor instance for the oldest that haven't yet migrated to MLC. This PR makes it up to par with the internal version and is fairly safe.

Also includes some fixes to the placeholder typing that wasn't entirely working as expected.

Closes #6399

@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:31pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:31pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 28.48 KB (0%)
lexical - esm 28.29 KB (0%)
@lexical/rich-text - cjs 36.9 KB (0%)
@lexical/rich-text - esm 28.14 KB (0%)
@lexical/plain-text - cjs 35.49 KB (0%)
@lexical/plain-text - esm 25.34 KB (0%)
@lexical/react - cjs 38.8 KB (0%)
@lexical/react - esm 29.31 KB (0%)

@zurfyx zurfyx mentioned this pull request Jul 9, 2024
Merged
@etrepum etrepum mentioned this pull request Jul 14, 2024
Closed
@zurfyx zurfyx added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 663bbd4 Jul 15, 2024
42 checks passed
@etrepum etrepum mentioned this pull request Jul 16, 2024
Merged
2wheeh pushed a commit to 2wheeh/lexical that referenced this pull request Jul 17, 2024
@zurfyx @2wheeh
Add ref to contenteditable (facebook#6381)
8c6eb60
@phazingazrael phazingazrael mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Expose <ContentEditable /> HTMLElement ref
3 participants
@zurfyx @Sahejkm @facebook-github-bot