Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical][Gallery] Add description in the card, option to render preview card at run time if no image #6372

Merged
merged 3 commits into from
Jul 4, 2024
Merged

[Lexical][Gallery] Add description in the card, option to render preview card at run time if no image #6372

merged 3 commits into from
Jul 4, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Jul 4, 2024

Description

  • Add description in the gallery card,
  • Add option in plugin list config to render preview card at run time if no image
  • Add collab example

Test plan

Screenshot 2024-07-04 at 7 42 58 PM

@vercel Vercel
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 11:43am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 11:43am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 4, 2024
@Sahejkm Sahejkm marked this pull request as ready for review July 4, 2024 11:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

size-limit report 📦

Path Size
lexical - cjs 28.47 KB (0%)
lexical - esm 28.28 KB (0%)
@lexical/rich-text - cjs 36.86 KB (0%)
@lexical/rich-text - esm 28.08 KB (0%)
@lexical/plain-text - cjs 35.49 KB (0%)
@lexical/plain-text - esm 25.3 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.27 KB (0%)

@Sahejkm Sahejkm added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 758bbea Jul 4, 2024
35 of 36 checks passed
2wheeh pushed a commit to 2wheeh/lexical that referenced this pull request Jul 17, 2024
@Sahejkm @2wheeh
[Lexical][Gallery] Add description in the card, option to render prev…
75aaf14 
…iew card at run time if no image (facebook#6372)
@phazingazrael phazingazrael mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sahejkm @potatowagon @facebook-github-bot