[Lexical][CI] Fix issues in after_approval workflow #6307
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
Sahejkm
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
potatowagon
as code owners
size-limit report 📦
|
| e2e-tests: | ||
| needs: pre_job | ||
| if: needs.pre_job.outputs.should_skip != 'true' && (github.event.review.state == 'approved' && !contains(github.event.pull_request.labels.*.name, 'extended-tests')) | ||
| uses: ./.github/workflows/call-e2e-all-tests.yml | ||
|
|
||
| flaky-test-notice: |
There was a problem hiding this comment.
can we please leave this here first? it still works on branches on this repo. ill like to try and fix instead of deleting it so quickly
There was a problem hiding this comment.
-
this keeps the pipeline red and its not a new issue we are trying to fix, its kinda wrong signal to PRs from forks, lemme check if we can figure out if PR is from fork else i would like to not make the CI red
-
we can readd this once we have the fix ready, i have tried multiple approaches in the past for the "addLabel" workflow with same issue but it didn't seem to work that time, so i don't think its a quick fix
There was a problem hiding this comment.
lemme check if we can figure out if PR is from fork else i would like to not make the CI red
this would be great, if its failing the ci and cant figure something out for the above then im ok to remove first.
There was a problem hiding this comment.
@potatowagon i tried couple if approaches but looks like "always()" is causing this step to always run regardless of whatever if else check i put related to ${{ github.event.pull_request.head.repo.full_name != 'facebook/lexical' }} anywhere in code.
would prefer removing this 1st till we get a better fix
There was a problem hiding this comment.
check this weird run
https://github.com/facebook/lexical/actions/runs/9510521267/job/26215150424
it evaluating (true && (needs.e2e)) as true
WHAT
Fix some issues in Lexical CI job after observing past runs :
flaky-test notice not working on "PRs from forks"
https://github.com/facebook/lexical/actions/runs/9506494216/job/26204471038?pr=6274
concurrent-workflow skipping all concurrent workflows running on multiple PRs rather just for the PR in focus, - change settings from 'always' to "same_content_newer".
Test plan
#6308