[Lexical][Meta] Add meta intern static docs config #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
Sahejkm
commented
Jun 12, 2024
Comment on lines
228
to
236
| markdown: { | ||
| format: 'md', | ||
| preprocessor: ({fileContent}) => | ||
| fileContent.replaceAll( | ||
| 'https://stackblitz.com/github/facebook/lexical/tree/main/', | ||
| STACKBLITZ_PREFIX, | ||
| ), | ||
| }, | ||
|
|
There was a problem hiding this comment.
this recent change is breaking JSX rendering in MD files and should be revisited later.
There was a problem hiding this comment.
have you tried just removing the format: 'md',?
etrepum
reviewed
Jun 13, 2024
Comment on lines
228
to
236
| markdown: { | ||
| format: 'md', | ||
| preprocessor: ({fileContent}) => | ||
| fileContent.replaceAll( | ||
| 'https://stackblitz.com/github/facebook/lexical/tree/main/', | ||
| STACKBLITZ_PREFIX, | ||
| ), | ||
| }, | ||
|
|
There was a problem hiding this comment.
it looks like this update to docusaurus-plugin-internaldocs-fb is switching from a markdown to mdx, so removing that configuration override should resolve the problem without throwing away the preprocessor which is useful for testing new examples in preview environments.
markdown: {
preprocessor: ({fileContent}) =>
fileContent.replaceAll(
'https://stackblitz.com/github/facebook/lexical/tree/main/',
STACKBLITZ_PREFIX,
),
},There was a problem hiding this comment.
this does the job indeed. Thanks @etrepum Bob!
Sahejkm
requested review from
zurfyx,
fantactuka,
acywatson and
Fetz
as code owners
potatowagon
reviewed
Jun 13, 2024
potatowagon
approved these changes
Jun 13, 2024
This was referenced Jul 23, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
WHY