-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lexical][Size-Checks] Measure both cjs/esm builds for regression checks #6219
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Is there a reason to track dev size? It's not really clear what that would help with, since size is presumably not a primary concern for dev. It might be more useful to track the cjs and esm prod builds (probably not at Meta, but most other places are likely using esm or soon will be) |
thanks for reviewing Bob, Makes sense to me. Updated. lmk WDYT now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it would work, but could be a bit simpler by using the exports for lookup instead of manipulating the paths directly
Resolved comments, thanks for rereview! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
test failures look unrelated, will check separately. Seems to impact other builds as well like https://github.com/facebook/lexical/pull/6216/checks |
WHAT
follow up on #6137
WHY
Test