Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-devtools] Chore: Safari App Store review fixes #6213

Merged
merged 2 commits into from
May 30, 2024
Merged

[lexical-devtools] Chore: Safari App Store review fixes #6213

merged 2 commits into from
May 30, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented May 30, 2024

Description

  • Fix: When clicked on ”Quit and Open Safari Extensions Preferences”, it quits the app but did not launch Safari Extensions Preferences Panel.
  • Added devtools extension specific support section to Lexical website as per Apple's requirements

Test plan

See website preview

@StyleT
fix(@lexical/devtools): When clicked on ”Quit and Open Safari Extensi…
aeedb11 
…ons Preferences”, it quits the app but did not launch Safari Extensions Preferences Panel.
@StyleT
feat(@lexical/devtools): Added devtools extension specific support se…
e4f5639 
…ction to Lexical website
@vercel Vercel
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:21pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:21pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical 23.95 KB (0%)
@lexical/rich-text 34.64 KB (0%)
@lexical/plain-text 34.62 KB (0%)
@lexical/react 149.36 KB (0%)

@StyleT StyleT marked this pull request as ready for review May 30, 2024 15:24
@lexical-bot lexical-bot added the extended-tests Run extended e2e tests on a PR label May 30, 2024
@StyleT StyleT added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 0e2404e May 30, 2024
39 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StyleT @thegreatercurve @facebook-github-bot @lexical-bot