Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lexical][CI] Add more packages for size limit regressions check #6209

Merged
merged 8 commits into from
May 30, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 30, 2024

WHAT

Add @lexical/react package for size limit regressions check, follows up on #6137

WHY

  • While supporting changes to making Lexical compatible to React 19, there was a size regression in the Meta internal build but wasn't detected in the external build.

  • adding @lexical/react package to size limit check to capture the size limit changes on each PR

TEST PLAN

sahejk@sahejk-mbp lexical % npx size-limit                           
✔ Adding to empty webpack project
✔ Running JS in headless Chrome
  
  lexical
  Size:         22.5 kB with all dependencies, minified and brotlied
  Loading time: 440 ms  on slow 3G
  
  @lexical/rich-text
  Size:         33.25 kB with all dependencies, minified and brotlied
  Loading time: 650 ms   on slow 3G
  
  @lexical/plain-text
  Size:         33.21 kB with all dependencies, minified and brotlied
  Loading time: 649 ms   on slow 3G
  
  @lexical/react
  Size:         150.38 kB with all dependencies, minified and brotlied
  Loading time: 3 s       on slow 3G
  
sahejk@sahejk-mbp lexical % 

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 10:22am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 10:22am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2024
Copy link

github-actions bot commented May 30, 2024

size-limit report 📦

Path Size
packages/lexical/dist/Lexical.js 23.95 KB (0%)
packages/lexical-rich-text/dist/LexicalRichText.js 34.64 KB (0%)
packages/lexical-plain-text/dist/LexicalPlainText.js 34.62 KB (0%)

@Sahejkm Sahejkm marked this pull request as ready for review May 30, 2024 09:23
@Sahejkm Sahejkm changed the title [testing] Add more packages for size limit regressions check [Lexical][CI] Add more packages for size limit regressions check May 30, 2024
potatowagon
potatowagon previously approved these changes May 30, 2024
@lexical-bot lexical-bot added the extended-tests Run extended e2e tests on a PR label May 30, 2024
.size-limit.js Outdated Show resolved Hide resolved
@Sahejkm Sahejkm added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit bd0c209 May 30, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants