-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[*] Feature: Automated nightly releases #6204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
c944663
to
7ce9397
Compare
85f89fd
to
98358f2
Compare
This is the current release procedure for public releases, at least as of | ||
May 2024 (~0.15.0). | ||
|
||
The main branch should be "frozen" during this procedure (no other PRs should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello thanks for this! pardon my qns:
-
what are the signals for when the release is happening? do we monitor in the actions tab for when the release workflows (im assuming call-npm-publish.yml) is running?
-
is there a way to automate the freezing? so PRs dont accidentally get merged while the release is happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are process questions that I don't have answers for, I'm merely documenting the way I've been told it works, but I did add some notes about the risk. @ivailop7 or @acywatson may be able to provide more detail. I think the answer might be that releases happen fairly quickly and PRs don't get merged that often when several core maintainers are working on a release so the potential inconsistency is just ignored.
I think we should change it so that this isn't a concern, but the scope of this PR is to enable nightly releases and not to change the existing release process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signal that a release is happening would be a release PR is up. Hopefully they would run the npm publish immediately after merge. That said, there are straightforward ways to change the process so that there is not a reason to freeze main, but that is out of scope here.
Just FYI the repository that I was testing this with is correctly doing nightly releases by cron job
|
We'll need @acywatson for this one |
Description
Refactor release workflow to use reusable workflows so the work can be shared
Add a nightly workflow to create a release every night in the nightly channel
Maintain release channel branches (
latest__release
,nightly__release
) so that we will have the option to build the docs site from the latest released version instead of or in addition to main (#6144)Closes #6169
Test plan
Future Considerations