Skip to content

[*] Feature: Automated nightly releases #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 9, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented May 30, 2024

Description

Refactor release workflow to use reusable workflows so the work can be shared

Add a nightly workflow to create a release every night in the nightly channel

Maintain release channel branches (latest__release, nightly__release) so that we will have the option to build the docs site from the latest released version instead of or in addition to main (#6144)

Closes #6169

Test plan

Future Considerations

  • Fix release process to use the same tag for both GitHub and NPM releases (the nightly release does not have this issue, only manual workflow_dispatch releases with a PR)
  • Do not do a nightly release when there are no changes since the last one

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:06pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:06pm

Copy link

github-actions bot commented May 30, 2024

size-limit report 📦

Path Size
lexical 23.95 KB (0%)
@lexical/rich-text 34.64 KB (0%)
@lexical/plain-text 34.62 KB (0%)
@lexical/react 149.36 KB (0%)

This is the current release procedure for public releases, at least as of
May 2024 (~0.15.0).

The main branch should be "frozen" during this procedure (no other PRs should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello thanks for this! pardon my qns:

  1. what are the signals for when the release is happening? do we monitor in the actions tab for when the release workflows (im assuming call-npm-publish.yml) is running?

  2. is there a way to automate the freezing? so PRs dont accidentally get merged while the release is happening.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are process questions that I don't have answers for, I'm merely documenting the way I've been told it works, but I did add some notes about the risk. @ivailop7 or @acywatson may be able to provide more detail. I think the answer might be that releases happen fairly quickly and PRs don't get merged that often when several core maintainers are working on a release so the potential inconsistency is just ignored.

I think we should change it so that this isn't a concern, but the scope of this PR is to enable nightly releases and not to change the existing release process.

Copy link
Collaborator Author

@etrepum etrepum May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signal that a release is happening would be a release PR is up. Hopefully they would run the npm publish immediately after merge. That said, there are straightforward ways to change the process so that there is not a reason to freeze main, but that is out of scope here.

@etrepum
Copy link
Collaborator Author

etrepum commented May 31, 2024

Just FYI the repository that I was testing this with is correctly doing nightly releases by cron job

@ivailop7
Copy link
Collaborator

ivailop7 commented Jun 2, 2024

We'll need @acywatson for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Automated nightly releases
5 participants