Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emojis from emoticons plugins #6188

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove emojis from emoticons plugins #6188

merged 1 commit into from
May 28, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented May 28, 2024

This logic for just 4 emojis doesn't bring any value and the slice(i, i + 2) is unintentionally cutting emojis in half

Screen.Recording.2024-05-28.at.6.18.34.PM.mov

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 10:20pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 10:20pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2024
Copy link

github-actions bot commented May 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.95 KB (0%) 480 ms (0%) 324 ms (+935.3% 🔺) 803 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.63 KB (0%) 693 ms (0%) 361 ms (+217.87% 🔺) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.61 KB (0%) 693 ms (0%) 418 ms (+291.17% 🔺) 1.2 s

@lexical-bot lexical-bot added the extended-tests Run extended e2e tests on a PR label May 28, 2024
@zurfyx zurfyx added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 1a129e7 May 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants